Page MenuHomePhabricator

Return milestone information in project.search
ClosedPublic

Authored by epriestley on Jan 8 2017, 7:32 PM.
Tags
None
Referenced Files
F14757348: D17153.id41251.diff
Wed, Jan 22, 12:27 AM
F14755039: D17153.id41257.diff
Tue, Jan 21, 3:44 PM
Unknown Object (File)
Sun, Jan 5, 12:57 PM
Unknown Object (File)
Fri, Jan 3, 9:22 AM
Unknown Object (File)
Tue, Dec 31, 5:18 PM
Unknown Object (File)
Tue, Dec 31, 11:21 AM
Unknown Object (File)
Dec 20 2024, 11:32 AM
Unknown Object (File)
Dec 19 2024, 12:56 AM
Subscribers
None

Details

Summary

Ref T12074.

  • project.search now returns milestones by default.
  • A new constraint, isMilestone, allows filtering to milestones, non-milestones, or both (API and web UI).
  • project.search now returns a milestone number for milestones, or null for non-milestones.
NOTE: Existing custom saved queries in projects which previously did not return milestones now will. I expect this to have little-to-no impact on users, and these queries are easy to correct, but I'll note this in changelogs.
Test Plan
  • Ran various queries with project.search and in the web UI, searching for milestones, non-milestones, and both.
  • Web UI default behavior (no milestones) is unchanged, but you can now get milestones if you want them.
  • Queried a milestone by ID/PHID via API.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 8 2017, 7:51 PM
This revision was automatically updated to reflect the committed changes.