Page MenuHomePhabricator

Return milestone information in project.search
ClosedPublic

Authored by epriestley on Jan 8 2017, 7:32 PM.
Tags
None
Referenced Files
F14063919: D17153.diff
Mon, Nov 18, 8:50 PM
F13979736: D17153.diff
Oct 19 2024, 6:11 AM
F13971743: D17153.id41251.diff
Oct 17 2024, 3:06 PM
Unknown Object (File)
Sep 24 2024, 1:55 AM
Unknown Object (File)
Sep 22 2024, 8:02 AM
Unknown Object (File)
Sep 15 2024, 6:42 PM
Unknown Object (File)
Sep 2 2024, 11:20 AM
Unknown Object (File)
Sep 1 2024, 12:23 PM
Subscribers
None

Details

Summary

Ref T12074.

  • project.search now returns milestones by default.
  • A new constraint, isMilestone, allows filtering to milestones, non-milestones, or both (API and web UI).
  • project.search now returns a milestone number for milestones, or null for non-milestones.
NOTE: Existing custom saved queries in projects which previously did not return milestones now will. I expect this to have little-to-no impact on users, and these queries are easy to correct, but I'll note this in changelogs.
Test Plan
  • Ran various queries with project.search and in the web UI, searching for milestones, non-milestones, and both.
  • Web UI default behavior (no milestones) is unchanged, but you can now get milestones if you want them.
  • Queried a milestone by ID/PHID via API.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 8 2017, 7:51 PM
This revision was automatically updated to reflect the committed changes.