Page MenuHomePhabricator

Make some Differential comment actions (like "Accept" and "Reject") conflict with one another
ClosedPublic

Authored by epriestley on Jan 2 2017, 7:22 PM.
Tags
None
Referenced Files
F15472215: D17132.id41201.diff
Sat, Apr 5, 11:27 AM
F15448712: D17132.id41201.diff
Fri, Mar 28, 6:31 AM
F15448487: D17132.id41201.diff
Fri, Mar 28, 5:11 AM
F15444327: D17132.id.diff
Thu, Mar 27, 9:03 AM
F15440633: D17132.diff
Wed, Mar 26, 1:55 PM
F15427955: D17132.id41198.diff
Sun, Mar 23, 5:21 PM
F15408654: D17132.id41198.diff
Wed, Mar 19, 12:37 AM
F15392988: D17132.diff
Sat, Mar 15, 6:44 PM
Subscribers
None

Details

Summary

Ref T11114. When a user selects "Accept", and then selects "Reject", remove the "Accept". It does not make sense to both accept and reject a revision.

For now, every one of the "actions" conflicts: accept, reject, resign, claim, close, commandeer, etc, etc. I couldn't come up with any combinations that it seems like users are reasonably likely to want to try, and we haven't received combo-action requests in the past that I can recall.

Test Plan
  • Selected "Accept", then selected "Reject". One replaced the other.
  • Selected "Accept", then selected "Change Subscribers". Both co-existed happily.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 2 2017, 7:36 PM
This revision was automatically updated to reflect the committed changes.