Page MenuHomePhabricator

Make restricted objects in commit messages work more consistently with the web UI
ClosedPublic

Authored by epriestley on Jan 1 2017, 5:05 PM.
Tags
None
Referenced Files
F17733629: D17124.diff
Sun, Jul 20, 8:35 AM
Unknown Object (File)
May 30 2025, 1:51 AM
Unknown Object (File)
May 29 2025, 7:32 AM
Unknown Object (File)
May 9 2025, 12:41 PM
Unknown Object (File)
Apr 28 2025, 1:54 AM
Unknown Object (File)
Apr 27 2025, 7:58 AM
Unknown Object (File)
Apr 20 2025, 7:44 PM
Unknown Object (File)
Apr 5 2025, 11:11 AM
Subscribers
None

Details

Summary

Fixes T11344. In the web UI, if a field like "Subscribers" on an object (like a task) contains values you don't have permission to see, you see tokens for them (like "Restricted Project") but not their names.

Make commit messages work the same way: you see the PHID, and can remove it or leave it there, but can't see the underlying name.

(We have to render an actual PHID rather than just "Restricted Thing" because we have to be able to figure out what edit the user is actually trying to make.)

Test Plan

Interacted with a revision via the CLI that had project reviewers I couldn't see.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 1 2017, 5:41 PM
This revision was automatically updated to reflect the committed changes.