Page MenuHomePhabricator

Make restricted objects in commit messages work more consistently with the web UI
ClosedPublic

Authored by epriestley on Jan 1 2017, 5:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 12:28 AM
Unknown Object (File)
Fri, Dec 13, 1:14 PM
Unknown Object (File)
Thu, Dec 5, 7:34 PM
Unknown Object (File)
Sun, Dec 1, 5:00 PM
Unknown Object (File)
Fri, Nov 29, 9:06 PM
Unknown Object (File)
Thu, Nov 28, 8:00 PM
Unknown Object (File)
Fri, Nov 22, 7:46 PM
Unknown Object (File)
Nov 19 2024, 10:04 AM
Subscribers
None

Details

Summary

Fixes T11344. In the web UI, if a field like "Subscribers" on an object (like a task) contains values you don't have permission to see, you see tokens for them (like "Restricted Project") but not their names.

Make commit messages work the same way: you see the PHID, and can remove it or leave it there, but can't see the underlying name.

(We have to render an actual PHID rather than just "Restricted Thing" because we have to be able to figure out what edit the user is actually trying to make.)

Test Plan

Interacted with a revision via the CLI that had project reviewers I couldn't see.

Diff Detail

Repository
rP Phabricator
Branch
parse5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15069
Build 19777: Run Core Tests
Build 19776: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jan 1 2017, 5:41 PM
This revision was automatically updated to reflect the committed changes.