Page MenuHomePhabricator

Make restricted objects in commit messages work more consistently with the web UI
ClosedPublic

Authored by epriestley on Jan 1 2017, 5:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 26, 7:12 PM
Unknown Object (File)
Jan 23 2024, 9:51 AM
Unknown Object (File)
Jan 21 2024, 7:59 PM
Unknown Object (File)
Jan 1 2024, 3:54 AM
Unknown Object (File)
Dec 27 2023, 9:09 AM
Unknown Object (File)
Dec 25 2023, 9:48 PM
Unknown Object (File)
Dec 21 2023, 3:28 PM
Unknown Object (File)
Dec 14 2023, 12:20 PM
Subscribers
None

Details

Summary

Fixes T11344. In the web UI, if a field like "Subscribers" on an object (like a task) contains values you don't have permission to see, you see tokens for them (like "Restricted Project") but not their names.

Make commit messages work the same way: you see the PHID, and can remove it or leave it there, but can't see the underlying name.

(We have to render an actual PHID rather than just "Restricted Thing" because we have to be able to figure out what edit the user is actually trying to make.)

Test Plan

Interacted with a revision via the CLI that had project reviewers I couldn't see.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 1 2017, 5:41 PM
This revision was automatically updated to reflect the committed changes.