Ref T11114. This restores:
- Commandeering should exeucte Herald.
- Commandeering should swap reviewers.
- "Request Review" on an "Accepted" revision should downgrade reviewers so they have to accept again.
Details
Details
- Reviewers
chad - Maniphest Tasks
- T11114: Move Differential to EditEngine
- Commits
- rPb373dcef7448: Restore some minor state behaviors to Differential on EditEngine
- Commandeered, saw Herald run and reviewers swap.
- Requested review of an accepted revision, saw it drop down to "Needs Review" with "Accepted Prior" on the reviewer.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- haunt12
- Lint
Lint Passed Severity Location Code Message Advice src/applications/differential/editor/DifferentialTransactionEditor.php:304 XHP16 TODO Comment - Unit
Tests Passed - Build Status
Buildable 15050 Build 19752: Run Core Tests Build 19751: arc lint + arc unit