Page MenuHomePhabricator

Restore some minor state behaviors to Differential on EditEngine
ClosedPublic

Authored by epriestley on Dec 31 2016, 5:24 PM.
Tags
None
Referenced Files
F22581011: D17118.id41162.diff
Sun, Sep 27, 6:41 PM
Unknown Object (File)
Jun 12 2026, 12:58 AM
Unknown Object (File)
Mar 23 2026, 11:19 PM
Unknown Object (File)
Mar 17 2026, 2:43 AM
Unknown Object (File)
Mar 16 2026, 10:12 AM
Unknown Object (File)
Mar 11 2026, 9:29 AM
Unknown Object (File)
Mar 11 2026, 9:28 AM
Unknown Object (File)
Mar 4 2026, 12:00 AM
Subscribers
None

Details

Summary

Ref T11114. This restores:

  • Commandeering should exeucte Herald.
  • Commandeering should swap reviewers.
  • "Request Review" on an "Accepted" revision should downgrade reviewers so they have to accept again.
Test Plan
  • Commandeered, saw Herald run and reviewers swap.
  • Requested review of an accepted revision, saw it drop down to "Needs Review" with "Accepted Prior" on the reviewer.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad edited edge metadata.
This revision is now accepted and ready to land.Dec 31 2016, 6:03 PM
This revision was automatically updated to reflect the committed changes.