Differential D17118

Restore some minor state behaviors to Differential on EditEngine
ClosedPublic
Actions

Authored by epriestley on Dec 31 2016, 5:24 PM.

Tags

None

Referenced Files

	F14376699: D17118.diff
	Sat, Dec 21, 12:10 AM

	Unknown Object (File)
	Sun, Dec 15, 5:31 AM

	Unknown Object (File)
	Sat, Dec 14, 11:30 AM

	Unknown Object (File)
	Sat, Dec 7, 6:42 AM

	Unknown Object (File)
	Tue, Dec 3, 5:28 PM

	Unknown Object (File)
	Tue, Dec 3, 8:44 AM

	Unknown Object (File)
	Sat, Nov 23, 1:40 PM

	Unknown Object (File)
	Nov 19 2024, 3:04 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T11114: Move Differential to EditEngine

Commits

rPb373dcef7448: Restore some minor state behaviors to Differential on EditEngine

Summary

Ref T11114. This restores:

Commandeering should exeucte Herald.
Commandeering should swap reviewers.
"Request Review" on an "Accepted" revision should downgrade reviewers so they have to accept again.

Test Plan

Commandeered, saw Herald run and reviewers swap.
Requested review of an accepted revision, saw it drop down to "Needs Review" with "Accepted Prior" on the reviewer.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Dec 31 2016, 5:24 PM

chad accepted this revision.Dec 31 2016, 6:03 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 31 2016, 6:03 PM

Closed by commit rPb373dcef7448: Restore some minor state behaviors to Differential on EditEngine (authored by epriestley, committed by epriestley). · Explain WhyDec 31 2016, 6:11 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialTransactionEditor.php

98 lines

transactions/

editengine/

PhabricatorEditEngine.php

4 lines

Diff 41175

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...

src/applications/transactions/editengine/PhabricatorEditEngine.php

Loading...