Page MenuHomePhabricator
Differential D17117

Restore quote and warning behaviors to Differential EditEngine comment area
ClosedPublic
Actions

Authored by epriestley on Dec 31 2016, 5:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 28, 11:58 AM
Unknown Object (File)
Wed, Apr 24, 6:10 AM
Unknown Object (File)
Fri, Apr 19, 5:59 PM
Unknown Object (File)
Thu, Apr 11, 9:17 AM
Unknown Object (File)
Sun, Apr 7, 5:59 AM
Unknown Object (File)
Apr 3 2024, 4:06 PM
Unknown Object (File)
Mar 31 2024, 7:23 PM
Unknown Object (File)
Mar 30 2024, 3:47 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11114: Move Differential to EditEngine
Commits
rP9b4090af5565: Restore quote and warning behaviors to Differential EditEngine comment area
Summary

Ref T11114. This restores warnings (e.g., failing unit tests) and fixes "Quote" behavior for comments.

Test Plan
  • Quoted a comment.
  • Viewed a warning.

Screen Shot 2016-12-31 at 8.59.22 AM.png (444×1 px, 49 KB)

Diff Detail

Repository
rP Phabricator
Branch
haunt11
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15049
Build 19750: Run Core Tests
Build 19749: arc lint + arc unit

Event Timeline

epriestley created this revision.Dec 31 2016, 5:01 PM
chad added inline comments.Dec 31 2016, 5:35 PM
src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
351

Hows this look on mobile? I'm surprised we don't already have CSS for this, but maybe it didn't come up during the recent redesign.

epriestley added a comment.Dec 31 2016, 5:36 PM

Only Differential and Ponder (and maybe Diffusion?) put messages in the comment area, as far as I know, so it hasn't come up in other applications yet, I think.

epriestley added a comment.Dec 31 2016, 5:41 PM

Mobile:

Screen Shot 2016-12-31 at 9.40.46 AM.png (1×752 px, 111 KB)

chad edited edge metadata.Dec 31 2016, 5:54 PM

Yeah I'd add a CSS class for it, with 16px (desktop) 8px (mobile) margin over using phui-box.

chad accepted this revision.Dec 31 2016, 5:57 PM
chad edited edge metadata.

(I can clean that up, if you like)

This revision is now accepted and ready to land.Dec 31 2016, 5:57 PM
epriestley added a comment.Dec 31 2016, 6:03 PM

All yours.

Closed by commit rP9b4090af5565: Restore quote and warning behaviors to Differential EditEngine comment area (authored by epriestley, committed by epriestley). · Explain WhyDec 31 2016, 6:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
controller/
56 lines
transactions/
view/
19 lines

Diff 41161

View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php

Loading...
Phabricator · Built by Phacility