Differential D17117

Restore quote and warning behaviors to Differential EditEngine comment area
ClosedPublic
Actions

Authored by epriestley on Dec 31 2016, 5:01 PM.

Details

Reviewers

chad

Maniphest Tasks

T11114: Move Differential to EditEngine

Commits

rP9b4090af5565: Restore quote and warning behaviors to Differential EditEngine comment area

Summary

Ref T11114. This restores warnings (e.g., failing unit tests) and fixes "Quote" behavior for comments.

Test Plan

Quoted a comment.
Viewed a warning.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Dec 31 2016, 5:01 PM

chad added inline comments.Dec 31 2016, 5:35 PM

src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
351	Hows this look on mobile? I'm surprised we don't already have CSS for this, but maybe it didn't come up during the recent redesign.

Only Differential and Ponder (and maybe Diffusion?) put messages in the comment area, as far as I know, so it hasn't come up in other applications yet, I think.

Mobile:

Screen Shot 2016-12-31 at 9.40.46 AM.png (1×752 px, 111 KB)

Yeah I'd add a CSS class for it, with 16px (desktop) 8px (mobile) margin over using phui-box.

(I can clean that up, if you like)

This revision is now accepted and ready to land.Dec 31 2016, 5:57 PM

All yours.

Closed by commit rP9b4090af5565: Restore quote and warning behaviors to Differential EditEngine comment area (authored by epriestley, committed by epriestley). · Explain WhyDec 31 2016, 6:11 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialRevisionViewController.php

56 lines

transactions/

view/

PhabricatorApplicationTransactionCommentView.php

19 lines

Diff 41174

View Options

src/applications/differential/controller/DifferentialRevisionViewController.php