Page MenuHomePhabricator

Make inline comment preview and submission mostly work on EditEngine
ClosedPublic

Authored by epriestley on Dec 30 2016, 10:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 29, 8:55 AM
Unknown Object (File)
Tue, May 27, 10:54 AM
Unknown Object (File)
Apr 27 2025, 9:34 PM
Unknown Object (File)
Apr 26 2025, 7:39 PM
Unknown Object (File)
Apr 26 2025, 10:43 AM
Unknown Object (File)
Apr 26 2025, 5:38 AM
Unknown Object (File)
Mar 30 2025, 7:00 AM
Unknown Object (File)
Mar 27 2025, 11:56 PM
Subscribers
None

Details

Summary

Ref T11114. This comments nearly working on EditEngine. Only significant issue I caught is that the "View" link doesn't render properly because it depends on JS which is tricky to hook up. I'll clean that up in a future diff.

Test Plan

Screen Shot 2016-12-30 at 2.07.01 PM.png (544×801 px, 53 KB)

Diff Detail

Repository
rP Phabricator
Branch
haunt10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15046
Build 19746: Run Core Tests
Build 19745: arc lint + arc unit

Event Timeline

chad edited edge metadata.
This revision is now accepted and ready to land.Dec 30 2016, 10:58 PM
This revision was automatically updated to reflect the committed changes.