Page MenuHomePhabricator

Make inline comment preview and submission mostly work on EditEngine
ClosedPublic

Authored by epriestley on Dec 30 2016, 10:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 26, 7:11 PM
Unknown Object (File)
Sat, Mar 23, 3:45 PM
Unknown Object (File)
Feb 17 2024, 10:16 AM
Unknown Object (File)
Feb 13 2024, 7:48 AM
Unknown Object (File)
Feb 7 2024, 1:50 PM
Unknown Object (File)
Feb 3 2024, 1:40 PM
Unknown Object (File)
Jan 22 2024, 5:13 PM
Unknown Object (File)
Dec 27 2023, 9:08 AM
Subscribers
None

Details

Summary

Ref T11114. This comments nearly working on EditEngine. Only significant issue I caught is that the "View" link doesn't render properly because it depends on JS which is tricky to hook up. I'll clean that up in a future diff.

Test Plan

Screen Shot 2016-12-30 at 2.07.01 PM.png (544×801 px, 53 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad edited edge metadata.
This revision is now accepted and ready to land.Dec 30 2016, 10:58 PM
This revision was automatically updated to reflect the committed changes.