Page MenuHomePhabricator

Order actions sensibly within Differential revision comment action groups
ClosedPublic

Authored by epriestley on Dec 29 2016, 9:44 PM.
Tags
None
Referenced Files
F17842184: D17115.diff
Sat, Jul 26, 11:19 PM
Unknown Object (File)
Mon, Jun 30, 3:59 PM
Unknown Object (File)
Sat, Jun 28, 1:12 PM
Unknown Object (File)
Jun 17 2025, 3:55 PM
Unknown Object (File)
Jun 1 2025, 9:49 AM
Unknown Object (File)
May 29 2025, 3:43 PM
Unknown Object (File)
May 29 2025, 8:55 AM
Unknown Object (File)
May 28 2025, 7:49 AM
Subscribers
None

Details

Summary

Ref T11114. See D17114 for some discussion.

For review actions: accept, reject, resign.

For revision actions, order is basically least-severe to most-severe action pairs: plan changes, request review, close, reopen, abandon, reclaim, commandeer.

Test Plan

Viewed revisions as an author and a reviewer, saw sensible action order within action groups.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad edited edge metadata.
This revision is now accepted and ready to land.Dec 30 2016, 5:56 PM
This revision was automatically updated to reflect the committed changes.