Page MenuHomePhabricator

Order actions sensibly within Differential revision comment action groups
ClosedPublic

Authored by epriestley on Dec 29 2016, 9:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 1, 10:15 AM
Unknown Object (File)
Sat, Jan 14, 7:59 AM
Unknown Object (File)
Sat, Jan 14, 7:59 AM
Unknown Object (File)
Jan 7 2023, 1:32 AM
Unknown Object (File)
Dec 26 2022, 2:09 PM
Unknown Object (File)
Nov 29 2022, 6:05 PM
Unknown Object (File)
Nov 29 2022, 6:05 PM
Unknown Object (File)
Nov 29 2022, 6:05 PM
Subscribers
None

Details

Summary

Ref T11114. See D17114 for some discussion.

For review actions: accept, reject, resign.

For revision actions, order is basically least-severe to most-severe action pairs: plan changes, request review, close, reopen, abandon, reclaim, commandeer.

Test Plan

Viewed revisions as an author and a reviewer, saw sensible action order within action groups.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad edited edge metadata.
This revision is now accepted and ready to land.Dec 30 2016, 5:56 PM
This revision was automatically updated to reflect the committed changes.