Page MenuHomePhabricator

Restore "Accept", "Reject" and "Resign" actions to Differential on EditEngine
ClosedPublic

Authored by epriestley on Dec 29 2016, 6:53 PM.
Tags
None
Referenced Files
F17283945: D17113.diff
Wed, Jun 25, 11:32 PM
Unknown Object (File)
Sat, May 31, 5:00 AM
Unknown Object (File)
Thu, May 29, 8:55 AM
Unknown Object (File)
Wed, May 28, 9:41 AM
Unknown Object (File)
Tue, May 27, 6:52 PM
Unknown Object (File)
May 10 2025, 4:28 AM
Unknown Object (File)
Apr 27 2025, 8:17 AM
Unknown Object (File)
Apr 26 2025, 6:01 PM
Subscribers
None

Details

Summary

Ref T11114. Some rough edges, but this largely makes Accept, Reject and Resign work in the new EditEngine comment area.

Ref T11050. This lays a little bit of groundwork for having "resign" mean "I don't want to review this, even if projects or packages I'm a member of need to", not just "remove me personally as a user reviewer".

Test Plan

Accepted, rejected and resigned from revisions without any major state issues.

Diff Detail

Repository
rP Phabricator
Branch
haunt7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15042
Build 19739: Run Core Tests
Build 19738: arc lint + arc unit

Event Timeline

chad edited edge metadata.
This revision is now accepted and ready to land.Dec 29 2016, 6:59 PM
This revision was automatically updated to reflect the committed changes.