Page MenuHomePhabricator

Restore "Accept", "Reject" and "Resign" actions to Differential on EditEngine
ClosedPublic

Authored by epriestley on Dec 29 2016, 6:53 PM.
Tags
None
Referenced Files
F15525170: D17113.diff
Mon, Apr 21, 12:37 PM
F15523639: D17113.id41155.diff
Mon, Apr 21, 2:42 AM
F15505101: D17113.id.diff
Mon, Apr 14, 11:52 PM
F15444439: D17113.id.diff
Thu, Mar 27, 9:36 AM
F15441775: D17113.diff
Mar 26 2025, 7:50 PM
F15399948: D17113.id.diff
Mar 17 2025, 8:44 AM
Unknown Object (File)
Feb 25 2025, 12:11 PM
Unknown Object (File)
Feb 18 2025, 12:16 PM
Subscribers
None

Details

Summary

Ref T11114. Some rough edges, but this largely makes Accept, Reject and Resign work in the new EditEngine comment area.

Ref T11050. This lays a little bit of groundwork for having "resign" mean "I don't want to review this, even if projects or packages I'm a member of need to", not just "remove me personally as a user reviewer".

Test Plan

Accepted, rejected and resigned from revisions without any major state issues.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad edited edge metadata.
This revision is now accepted and ready to land.Dec 29 2016, 6:59 PM
This revision was automatically updated to reflect the committed changes.