Page MenuHomePhabricator

Restore "Accept", "Reject" and "Resign" actions to Differential on EditEngine
ClosedPublic

Authored by epriestley on Dec 29 2016, 6:53 PM.
Tags
None
Referenced Files
F18823121: D17113.id41155.diff
Thu, Oct 23, 10:17 AM
F18778212: D17113.id.diff
Sat, Oct 11, 8:31 AM
F18769888: D17113.id41170.diff
Wed, Oct 8, 9:44 AM
F18760115: D17113.id.diff
Mon, Oct 6, 8:05 AM
F18757589: D17113.diff
Sun, Oct 5, 6:17 PM
F18743643: D17113.id41170.diff
Fri, Oct 3, 12:21 AM
F18646887: D17113.diff
Sep 19 2025, 11:26 AM
F18600098: D17113.diff
Sep 13 2025, 9:00 AM
Subscribers
None

Details

Summary

Ref T11114. Some rough edges, but this largely makes Accept, Reject and Resign work in the new EditEngine comment area.

Ref T11050. This lays a little bit of groundwork for having "resign" mean "I don't want to review this, even if projects or packages I'm a member of need to", not just "remove me personally as a user reviewer".

Test Plan

Accepted, rejected and resigned from revisions without any major state issues.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad edited edge metadata.
This revision is now accepted and ready to land.Dec 29 2016, 6:59 PM
This revision was automatically updated to reflect the committed changes.