Page MenuHomePhabricator
Differential D17109

Restore "Plan Changes" and "Request Review" actions to Differential on EditEngine
ClosedPublic
Actions

Authored by epriestley on Dec 28 2016, 9:42 PM.
Tags
None
Referenced Files
F18619360: D17109.id.diff
Mon, Sep 15, 2:19 AM
F18600500: D17109.diff
Sat, Sep 13, 9:54 AM
F18599060: D17109.diff
Sat, Sep 13, 6:33 AM
F18108213: D17109.id41168.diff
Aug 11 2025, 5:31 AM
F18090044: D17109.id41168.diff
Aug 6 2025, 1:48 PM
F18086320: D17109.id.diff
Aug 5 2025, 9:05 PM
F18084785: D17109.diff
Aug 5 2025, 5:26 PM
F18078710: D17109.diff
Aug 4 2025, 8:20 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11114: Move Differential to EditEngine
Commits
rPdeb19b2d572d: Restore "Plan Changes" and "Request Review" actions to Differential on…
Summary

Ref T11114. This restores these actions.

One behavior is incomplete: "Request Review" on an accepted revision does not downgrade reviewers properly. I've noted this locally.

Test Plan

Planned changes and requested review of a revision.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Dec 28 2016, 9:42 PM
chad accepted this revision.Dec 29 2016, 5:59 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 29 2016, 5:59 PM
Closed by commit rPdeb19b2d572d: Restore "Plan Changes" and "Request Review" actions to Differential on… (authored by epriestley, committed by epriestley). · Explain WhyDec 31 2016, 6:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 41168

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionPlanChangesTransaction.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionRequestReviewTransaction.php

Loading...
Phabricator · Built by Phacility