Page MenuHomePhabricator
Differential D17094

Fix 20160122.project.1.boarddefault.php database upgrade patch
ClosedPublic
Actions

Authored by dereckson on Dec 19 2016, 6:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 9:54 AM
Unknown Object (File)
Mon, Apr 8, 11:12 PM
Unknown Object (File)
Fri, Apr 5, 6:30 AM
Unknown Object (File)
Wed, Apr 3, 5:30 PM
Unknown Object (File)
Mon, Apr 1, 11:57 PM
Unknown Object (File)
Tue, Mar 26, 7:35 PM
Unknown Object (File)
Tue, Mar 26, 2:35 PM
Unknown Object (File)
Tue, Mar 26, 2:35 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T12031: PhabricatorProjectWorkboardProfilePanel still defined in legacy database upgrade code
Commits
rP178466b82618: Fix 20160122.project.1.boarddefault.php database upgrade patch
Summary

Fixes T12031.

Test Plan

Upgraded a December 2015 Phabricator installation to current schema.

Diff Detail

Repository
rP Phabricator
Branch
arcpatch-D17094
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15004
Build 19676: arc lint + arc unit

Event Timeline

dereckson created this revision.Dec 19 2016, 6:04 PM
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 19 2016, 6:04 PM
Herald added a subscriber: epriestley. · View Herald Transcript
epriestley requested changes to this revision.Dec 19 2016, 6:23 PM
epriestley added a reviewer: epriestley.
epriestley added inline comments.
resources/sql/autopatches/20160122.project.1.boarddefault.php
53

Per T12031, this should more precisely be PhabricatorProjectWorkboardProfileMenuItem::MENUITEMKEY.

This revision now requires changes to proceed.Dec 19 2016, 6:23 PM
dereckson updated this revision to Diff 41117.Dec 19 2016, 8:43 PM
dereckson edited edge metadata.
dereckson marked an inline comment as done.

PhabricatorProjectWorkboardProfileMenuItem::MENUITEMKEY

Herald added a subscriber: Korvin. · View Herald TranscriptDec 19 2016, 8:43 PM
epriestley accepted this revision.Dec 19 2016, 8:52 PM
epriestley edited edge metadata.

Thanks!

This revision is now accepted and ready to land.Dec 19 2016, 8:52 PM
Closed by commit rP178466b82618: Fix 20160122.project.1.boarddefault.php database upgrade patch (authored by dereckson, committed by epriestley). · Explain WhyDec 19 2016, 8:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
6 lines

Diff 41117

View Options

resources/sql/autopatches/20160122.project.1.boarddefault.php

Loading...
Phabricator · Built by Phacility