Differential D17089

Simplify "Blame Revision" field in Differential
ClosedPublic
Actions

Authored by epriestley on Dec 16 2016, 6:07 PM.

Details

Reviewers

chad

Maniphest Tasks

T11114: Move Differential to EditEngine

Commits

rP895cdaca5d1f: Simplify "Blame Revision" field in Differential

Summary

Ref T11114. This is still mostly in use, but toss a few commit message parsing things.

Test Plan

Viewed/edited/upated blame rev from CLI/web UI.

Diff Detail

Repository

rP Phabricator

Branch

diff41

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14970
Build 19636: Run Core Tests
Build 19635: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 41081.Dec 16 2016, 6:07 PM

epriestley retitled this revision from to Simplify "Blame Revision" field in Differential.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11114: Move Differential to EditEngine.

chad accepted this revision.Dec 16 2016, 6:42 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 16 2016, 6:42 PM

Closed by commit rP895cdaca5d1f: Simplify "Blame Revision" field in Differential (authored by epriestley, committed by epriestley). · Explain WhyDec 16 2016, 8:03 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T12085: Upgrading: Changes to Differential Custom Fields in Commit Messages.Jan 9 2017, 5:32 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

customfield/

DifferentialBlameRevisionField.php

23 lines

Diff 41081

View Options

src/applications/differential/customfield/DifferentialBlameRevisionField.php

Simplify "Blame Revision" field in DifferentialClosedPublicActions