Differential D17084

Simplify "Test Plan" custom field
ClosedPublic
Actions

Authored by epriestley on Dec 16 2016, 5:40 PM.

Details

Reviewers

chad

Maniphest Tasks

T11114: Move Differential to EditEngine

Commits

rPc458f09dccb3: Simplify "Test Plan" custom field

Summary

Ref T11114. This leaves mail integration and UI integration, but strips all the editing (now handled by EditEngine) and commit message stuff (now handled by CommitMessageField).

Test Plan

Viewed and edited test plans and test plan transactions.

Diff Detail

Repository

rP Phabricator

Branch

diff36

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14965
Build 19626: Run Core Tests
Build 19625: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 41076.Dec 16 2016, 5:40 PM

epriestley retitled this revision from to Simplify "Test Plan" custom field.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11114: Move Differential to EditEngine.

chad accepted this revision.Dec 16 2016, 5:50 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 16 2016, 5:50 PM

Closed by commit rPc458f09dccb3: Simplify "Test Plan" custom field (authored by epriestley, committed by epriestley). · Explain WhyDec 16 2016, 6:24 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T12085: Upgrading: Changes to Differential Custom Fields in Commit Messages.Jan 9 2017, 5:32 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

customfield/

DifferentialTestPlanField.php

110 lines

storage/

DifferentialTransaction.php

2 lines

Diff 41076

View Options

src/applications/differential/customfield/DifferentialTestPlanField.php