Page MenuHomePhabricator
Differential D17069

Remove "Apply Patch" UI field from Differential
ClosedPublic
Actions

Authored by epriestley on Dec 16 2016, 2:27 PM.
Tags
None
Referenced Files
F14721739: D17069.diff
Fri, Jan 17, 10:56 PM
F14712438: D17069.id41057.diff
Fri, Jan 17, 3:48 PM
Unknown Object (File)
Sun, Jan 12, 11:02 PM
Unknown Object (File)
Wed, Jan 8, 5:36 AM
Unknown Object (File)
Wed, Jan 8, 5:36 AM
Unknown Object (File)
Tue, Dec 24, 9:44 AM
Unknown Object (File)
Tue, Dec 24, 2:46 AM
Unknown Object (File)
Sat, Dec 21, 10:10 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12026: Replace "apply patch" Differential advice with comprehensive instructions on "Download Raw Diff"
Commits
rPd12856b5d428: Remove "Apply Patch" UI field from Differential
Summary

Ref T12026. This simplifies the UI and makes T11114 easier. I plan to integrate this into "Download Raw Diff" in the future.

Test Plan
  • Browsed revisions.
  • Grepped for removed class name.

Diff Detail

Repository
rP Phabricator
Branch
diff21
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14946
Build 19590: Run Core Tests
Build 19589: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 41057.Dec 16 2016, 2:27 PM
epriestley retitled this revision from to Remove "Apply Patch" UI field from Differential.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T12026: Replace "apply patch" Differential advice with comprehensive instructions on "Download Raw Diff".
chad accepted this revision.Dec 16 2016, 3:29 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 16 2016, 3:29 PM
Closed by commit rPd12856b5d428: Remove "Apply Patch" UI field from Differential (authored by epriestley, committed by epriestley). · Explain WhyDec 16 2016, 6:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
differential/
config/
2 lines
customfield/

Diff 41057

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/config/PhabricatorDifferentialConfigOptions.php

Loading...
View Options

src/applications/differential/customfield/DifferentialApplyPatchField.php

Loading...
Phabricator · Built by Phacility