Page MenuHomePhabricator

Separate commit message parsing and validation from Conduit
ClosedPublic

Authored by epriestley on Dec 14 2016, 4:05 PM.
Tags
None
Referenced Files
F15551828: D17055.id.diff
Sun, Apr 27, 6:44 PM
F15546263: D17055.diff
Sat, Apr 26, 2:42 PM
F15509361: D17055.diff
Wed, Apr 16, 11:48 AM
F15452091: D17055.id41037.diff
Sat, Mar 29, 1:43 AM
F15449436: D17055.id41024.diff
Mar 28 2025, 10:15 AM
F15446987: D17055.id.diff
Mar 27 2025, 9:15 PM
F15420200: D17055.diff
Mar 21 2025, 12:09 PM
F15397890: D17055.id.diff
Mar 16 2025, 10:48 PM
Subscribers
None

Details

Summary

Ref T11114. I want to move this step away from custom fields. To start with, isolate all the parsing in one class with a clearer API boundary.

Next, I'll make this class use new field objects to perform parsing, without CustomField interactions.

Test Plan

Created and edited revisions from the CLI, using valid and invalid commit messages.

Diff Detail

Repository
rP Phabricator
Branch
diff15
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14912
Build 19533: Run Core Tests
Build 19532: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Better separate commit message parsing and validation from Conduit.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley retitled this revision from Better separate commit message parsing and validation from Conduit to Separate commit message parsing and validation from Conduit.Dec 14 2016, 4:13 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 14 2016, 4:48 PM
This revision was automatically updated to reflect the committed changes.