Differential D17055

Separate commit message parsing and validation from Conduit
ClosedPublic
Actions

Authored by epriestley on Dec 14 2016, 4:05 PM.

Details

Reviewers

chad

Maniphest Tasks

T11114: Move Differential to EditEngine

Commits

rP552c54668988: Separate commit message parsing and validation from Conduit

Summary

Ref T11114. I want to move this step away from custom fields. To start with, isolate all the parsing in one class with a clearer API boundary.

Next, I'll make this class use new field objects to perform parsing, without CustomField interactions.

Test Plan

Created and edited revisions from the CLI, using valid and invalid commit messages.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 41024.Dec 14 2016, 4:05 PM

epriestley retitled this revision from to Better separate commit message parsing and validation from Conduit.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11114: Move Differential to EditEngine.

epriestley retitled this revision from Better separate commit message parsing and validation from Conduit to Separate commit message parsing and validation from Conduit.Dec 14 2016, 4:13 PM

chad accepted this revision.Dec 14 2016, 4:48 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 14 2016, 4:48 PM

Closed by commit rP552c54668988: Separate commit message parsing and validation from Conduit (authored by epriestley, committed by epriestley). · Explain WhyDec 14 2016, 10:14 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T12085: Upgrading: Changes to Differential Custom Fields in Commit Messages.Jan 9 2017, 5:32 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

conduit/

DifferentialParseCommitMessageConduitAPIMethod.php

72 lines

parser/

DifferentialCommitMessageParser.php

95 lines

Diff 41037

View Options

src/applications/differential/conduit/DifferentialParseCommitMessageConduitAPIMethod.php