Page MenuHomePhabricator

Replace Differential Edit controller with EditEngine-driven EditPro controller
ClosedPublic

Authored by epriestley on Dec 14 2016, 2:42 PM.
Tags
None
Referenced Files
F15902649: D17054.diff
Sun, Jun 1, 9:54 AM
Unknown Object (File)
Sat, May 31, 2:12 AM
Unknown Object (File)
Thu, May 29, 11:18 PM
Unknown Object (File)
Thu, May 29, 8:52 AM
Unknown Object (File)
Wed, May 28, 6:20 PM
Unknown Object (File)
Tue, May 27, 9:26 PM
Unknown Object (File)
Sun, May 25, 8:08 PM
Unknown Object (File)
Sat, May 10, 10:50 PM
Subscribers
None

Details

Summary

Ref T11114. This replaces the old edit controller with a new one based entirely on EditEngine.

This removes the CustomFieldEditEngineExtension hack for Differential, since remaining field types are fairly straightforward and work with existing EditEngine support, as far as I can tell.

Test Plan
  • Created a revision via web diffs.
  • Updated a revision via web diffs.
  • Edited a revision via web.
  • Edited nonstandard custom fields ("Blame Revision", "JIRA Issues").
  • Created a revision via CLI.
  • Updated a revision via CLI.

Diff Detail

Repository
rP Phabricator
Branch
diff12
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14908
Build 19528: Run Core Tests
Build 19527: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Replace Differential Edit controller with EditEngine-driven EditPro controller.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 14 2016, 3:10 PM
This revision was automatically updated to reflect the committed changes.