Page MenuHomePhabricator

Replace Differential Edit controller with EditEngine-driven EditPro controller
ClosedPublic

Authored by epriestley on Dec 14 2016, 2:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 21 2026, 10:59 PM
Unknown Object (File)
Mar 15 2026, 5:40 PM
Unknown Object (File)
Jan 30 2026, 11:08 PM
Unknown Object (File)
Jan 11 2026, 11:05 AM
Unknown Object (File)
Nov 11 2025, 6:28 PM
Unknown Object (File)
Nov 11 2025, 5:57 PM
Unknown Object (File)
Nov 7 2025, 8:01 AM
Unknown Object (File)
Oct 8 2025, 11:35 AM
Subscribers
None

Details

Summary

Ref T11114. This replaces the old edit controller with a new one based entirely on EditEngine.

This removes the CustomFieldEditEngineExtension hack for Differential, since remaining field types are fairly straightforward and work with existing EditEngine support, as far as I can tell.

Test Plan
  • Created a revision via web diffs.
  • Updated a revision via web diffs.
  • Edited a revision via web.
  • Edited nonstandard custom fields ("Blame Revision", "JIRA Issues").
  • Created a revision via CLI.
  • Updated a revision via CLI.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Replace Differential Edit controller with EditEngine-driven EditPro controller.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 14 2016, 3:10 PM
This revision was automatically updated to reflect the committed changes.