Page MenuHomePhabricator

Replace Differential Edit controller with EditEngine-driven EditPro controller
ClosedPublic

Authored by epriestley on Dec 14 2016, 2:42 PM.
Tags
None
Referenced Files
F18620105: D17054.id41020.diff
Mon, Sep 15, 4:15 AM
F18614166: D17054.diff
Sun, Sep 14, 12:18 PM
F18614163: D17054.diff
Sun, Sep 14, 12:09 PM
F18594557: D17054.id.diff
Fri, Sep 12, 6:33 PM
F18587633: D17054.diff
Thu, Sep 11, 9:58 PM
F18532616: D17054.diff
Sun, Sep 7, 7:42 AM
F18091908: D17054.id41020.diff
Aug 7 2025, 2:50 AM
F18050450: D17054.id41023.diff
Aug 3 2025, 7:50 PM
Subscribers
None

Details

Summary

Ref T11114. This replaces the old edit controller with a new one based entirely on EditEngine.

This removes the CustomFieldEditEngineExtension hack for Differential, since remaining field types are fairly straightforward and work with existing EditEngine support, as far as I can tell.

Test Plan
  • Created a revision via web diffs.
  • Updated a revision via web diffs.
  • Edited a revision via web.
  • Edited nonstandard custom fields ("Blame Revision", "JIRA Issues").
  • Created a revision via CLI.
  • Updated a revision via CLI.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Replace Differential Edit controller with EditEngine-driven EditPro controller.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 14 2016, 3:10 PM
This revision was automatically updated to reflect the committed changes.