Page MenuHomePhabricator

Allow the new Differential EditEngine form to create/update diffs for revisions
ClosedPublic

Authored by epriestley on Dec 14 2016, 2:20 PM.
Tags
None
Referenced Files
F13162564: D17053.diff
Mon, May 6, 2:18 PM
Unknown Object (File)
Mon, Apr 29, 11:55 AM
Unknown Object (File)
Thu, Apr 25, 2:31 AM
Unknown Object (File)
Tue, Apr 23, 4:25 AM
Unknown Object (File)
Fri, Apr 19, 5:53 PM
Unknown Object (File)
Apr 6 2024, 10:16 AM
Unknown Object (File)
Apr 6 2024, 7:10 AM
Unknown Object (File)
Mar 30 2024, 3:27 AM
Subscribers
None

Details

Summary

Ref T11114. Much of this is around making the "comment-while-updating" flow work correctly.

Test Plan
  • Created new diffs by copy/pasting, then:
    • used one to create a new revision;
    • used one to update an existing revision, with a comment.

Diff Detail

Repository
rP Phabricator
Branch
diff11
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14907
Build 19526: Run Core Tests
Build 19525: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Allow the new Differential EditEngine form to create/update diffs for revisions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 14 2016, 3:08 PM
This revision was automatically updated to reflect the committed changes.