Page MenuHomePhabricator
Differential D17050

Add EditEngine + Modular Transactions for reviewers
ClosedPublic
Actions

Authored by epriestley on Dec 14 2016, 1:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 29, 2:51 PM
Unknown Object (File)
Wed, Apr 24, 10:49 PM
Unknown Object (File)
Tue, Apr 23, 11:22 PM
Unknown Object (File)
Mon, Apr 22, 9:11 AM
Unknown Object (File)
Fri, Apr 19, 5:53 PM
Unknown Object (File)
Fri, Apr 12, 10:23 PM
Unknown Object (File)
Thu, Apr 4, 8:01 AM
Unknown Object (File)
Wed, Apr 3, 10:53 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11114: Move Differential to EditEngine
Commits
rP7f99f2cde835: Add EditEngine + Modular Transactions for reviewers
Summary

Ref T11114. This one is a bit more complex, but I think I covered everything.

Test Plan
  • Added reviewers.
  • Removed reviewers.
  • Made reviewers blocking.
  • Made reviewers nonblocking.
  • Tried to make the author a reviewer.

Diff Detail

Repository
rP Phabricator
Branch
diff9
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php:113XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 14900
Build 19516: Run Core Tests
Build 19515: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 41011.Dec 14 2016, 1:17 AM
epriestley retitled this revision from to Add EditEngine + Modular Transactions for reviewers.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11114: Move Differential to EditEngine.
chad accepted this revision.Dec 14 2016, 1:41 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 14 2016, 1:41 AM
Closed by commit rP7f99f2cde835: Add EditEngine + Modular Transactions for reviewers (authored by epriestley, committed by epriestley). · Explain WhyDec 14 2016, 2:21 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
differential/
editor/
15 lines
storage/
18 lines
xaction/
350 lines
transactions/
storage/
2 lines

Diff 41011

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/editor/DifferentialRevisionEditEngine.php

Loading...
View Options

src/applications/differential/storage/DifferentialRevision.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorModularTransactionType.php

Loading...
Phabricator · Built by Phacility