Page MenuHomePhabricator
Differential D17050

Add EditEngine + Modular Transactions for reviewers
ClosedPublic
Actions

Authored by epriestley on Dec 14 2016, 1:17 AM.
Tags
None
Referenced Files
F14027905: D17050.id41011.diff
Fri, Nov 8, 10:29 AM
F14001590: D17050.id41011.diff
Fri, Oct 25, 9:54 AM
F13988365: D17050.id.diff
Mon, Oct 21, 2:54 PM
F13987418: D17050.id41015.diff
Mon, Oct 21, 9:23 AM
F13981084: D17050.id41015.diff
Oct 19 2024, 2:10 PM
F13975945: D17050.diff
Oct 18 2024, 12:18 PM
F13973181: D17050.diff
Oct 17 2024, 11:34 PM
Unknown Object (File)
Sep 30 2024, 4:00 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11114: Move Differential to EditEngine
Commits
rP7f99f2cde835: Add EditEngine + Modular Transactions for reviewers
Summary

Ref T11114. This one is a bit more complex, but I think I covered everything.

Test Plan
  • Added reviewers.
  • Removed reviewers.
  • Made reviewers blocking.
  • Made reviewers nonblocking.
  • Tried to make the author a reviewer.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 41011.Dec 14 2016, 1:17 AM
epriestley retitled this revision from to Add EditEngine + Modular Transactions for reviewers.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11114: Move Differential to EditEngine.
chad accepted this revision.Dec 14 2016, 1:41 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 14 2016, 1:41 AM
Closed by commit rP7f99f2cde835: Add EditEngine + Modular Transactions for reviewers (authored by epriestley, committed by epriestley). · Explain WhyDec 14 2016, 2:21 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
differential/
editor/
15 lines
storage/
18 lines
xaction/
350 lines
transactions/
storage/
2 lines

Diff 41015

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/editor/DifferentialRevisionEditEngine.php

Loading...
View Options

src/applications/differential/storage/DifferentialRevision.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorModularTransactionType.php

Loading...
Phabricator · Built by Phacility