Paths

Table of Contentst

Differential D17044

Begin adding "pro" modular transaction fields to Differential
ClosedPublic
Actions

Authored by epriestley on Dec 13 2016, 9:22 PM.

Tags

None

Referenced Files

	F13087104: D17044.diff
	Thu, Apr 25, 12:51 AM

	F13080857: D17044.id41007.diff
	Wed, Apr 24, 10:49 AM

	Unknown Object (File)
	Fri, Apr 19, 5:52 PM

	Unknown Object (File)
	Thu, Apr 11, 8:37 AM

	Unknown Object (File)
	Thu, Apr 4, 10:44 PM

	Unknown Object (File)
	Sat, Mar 30, 3:25 AM

	Unknown Object (File)
	Tue, Mar 26, 2:28 PM

	Unknown Object (File)
	Tue, Mar 26, 2:28 PM

Subscribers

None

Tokens

"Party Time" token, awarded by avivey.

Details

Reviewers

Maniphest Tasks

T11114: Move Differential to EditEngine

Commits

rP0906bf547b9a: Begin adding "pro" modular transaction fields to Differential

Summary

Ref T11114. Currently, all of Differential is extremely custom CustomFields. I want to back away from that somewhat and leverage more EditEngine / ModularTransactions infrastructure.

This allows EditEngine, ModularTransactions, and CustomFields to coexist in an uneasy peace. The "EditPro" controller applies a different edit than the CustomFields do, but everything works out in the end. I think.

Hopefully the horrible mess I am creating here will be short-lived.

Test Plan

Edited a revision with the normal editor.
Edited a revision with the pro editor.
Created a revision with arc diff.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40996.Dec 13 2016, 9:22 PM

epriestley retitled this revision from to Begin adding "pro" modular transaction fields to Differential.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11114: Move Differential to EditEngine.

chad accepted this revision.Dec 13 2016, 9:26 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 13 2016, 9:26 PM

Closed by commit rP0906bf547b9a: Begin adding "pro" modular transaction fields to Differential (authored by epriestley, committed by epriestley). · Explain WhyDec 13 2016, 10:50 PM

This revision was automatically updated to reflect the committed changes.

avivey awarded a token.Dec 13 2016, 10:57 PM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

6 lines

applications/

differential/

editor/

DifferentialRevisionEditEngine.php

12 lines

storage/

DifferentialTransaction.php

6 lines

xaction/

DifferentialRevisionTitleTransaction.php

57 lines

DifferentialRevisionTransactionType.php

4 lines

transactions/

storage/

PhabricatorModularTransaction.php

14 lines

Diff 41007

src/__phutil_library_map__.php

Loading...

src/applications/differential/editor/DifferentialRevisionEditEngine.php

Loading...

src/applications/differential/storage/DifferentialTransaction.php

Loading...

src/applications/differential/xaction/DifferentialRevisionTitleTransaction.php

Loading...

src/applications/differential/xaction/DifferentialRevisionTransactionType.php

Loading...

src/applications/transactions/storage/PhabricatorModularTransaction.php

Loading...