Page MenuHomePhabricator

Begin adding "pro" modular transaction fields to Differential
ClosedPublic

Authored by epriestley on Dec 13 2016, 9:22 PM.
Tags
None
Referenced Files
F18783167: D17044.id40996.diff
Mon, Oct 13, 4:24 AM
F18763215: D17044.id.diff
Mon, Oct 6, 11:16 PM
F18758339: D17044.diff
Sun, Oct 5, 9:55 PM
F18705742: D17044.diff
Sun, Sep 28, 12:53 PM
F18625971: D17044.id.diff
Sep 16 2025, 12:03 AM
F18570406: D17044.diff
Sep 10 2025, 3:24 AM
F18518720: D17044.id40996.diff
Sep 5 2025, 3:36 PM
F18482432: D17044.id40996.diff
Sep 3 2025, 3:18 PM
Subscribers
None
Tokens
"Party Time" token, awarded by avivey.

Details

Summary

Ref T11114. Currently, all of Differential is extremely custom CustomFields. I want to back away from that somewhat and leverage more EditEngine / ModularTransactions infrastructure.

This allows EditEngine, ModularTransactions, and CustomFields to coexist in an uneasy peace. The "EditPro" controller applies a different edit than the CustomFields do, but everything works out in the end. I think.

Hopefully the horrible mess I am creating here will be short-lived.

Test Plan
  • Edited a revision with the normal editor.
  • Edited a revision with the pro editor.
  • Created a revision with arc diff.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Begin adding "pro" modular transaction fields to Differential.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 13 2016, 9:26 PM
This revision was automatically updated to reflect the committed changes.