Page MenuHomePhabricator
Differential D17043

Add a very basic EditPro controller for Differential
ClosedPublic
Actions

Authored by epriestley on Dec 13 2016, 8:38 PM.
Tags
None
Referenced Files
F19141521: D17043.diff
Wed, Dec 10, 1:13 PM
F19076662: D17043.id40995.diff
Mon, Dec 1, 12:51 PM
F18877469: D17043.id.diff
Nov 6 2025, 8:57 AM
F18875064: D17043.diff
Nov 5 2025, 4:40 PM
F18855357: D17043.id41006.diff
Nov 1 2025, 5:00 AM
F18770823: D17043.diff
Oct 8 2025, 3:16 PM
F18760266: D17043.id.diff
Oct 6 2025, 8:48 AM
F18757285: D17043.diff
Oct 5 2025, 4:38 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11114: Move Differential to EditEngine
Commits
rPeda64b85497b: Add a very basic EditPro controller for Differential
Summary

Ref T11114. This doesn't really support anything yet, but technically works if you manually go to /editpro/.

Test Plan

Screen Shot 2016-12-13 at 12.33.12 PM.png (1×1 px, 146 KB)

Diff Detail

Repository
rP Phabricator
Branch
diff5
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/infrastructure/customfield/engineextension/PhabricatorCustomFieldEditEngineExtension.php:30XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 14884
Build 19492: Run Core Tests
Build 19491: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40995.Dec 13 2016, 8:38 PM
epriestley retitled this revision from to Add a very basic EditPro controller for Differential.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11114: Move Differential to EditEngine.
chad accepted this revision.Dec 13 2016, 9:12 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 13 2016, 9:12 PM
Closed by commit rPeda64b85497b: Add a very basic EditPro controller for Differential (authored by epriestley, committed by epriestley). · Explain WhyDec 13 2016, 10:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
4 lines
applications/
differential/
application/
2 lines
controller/
12 lines
editor/
66 lines
infrastructure/
customfield/
engineextension/
6 lines

Diff 40995

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/application/PhabricatorDifferentialApplication.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionEditProController.php

Loading...
View Options

src/applications/differential/editor/DifferentialRevisionEditEngine.php

Loading...
View Options

src/infrastructure/customfield/engineextension/PhabricatorCustomFieldEditEngineExtension.php

Loading...
Phabricator · Built by Phacility