Page MenuHomePhabricator

Remove default margin on selects
ClosedPublic

Authored by chad on Dec 1 2016, 5:05 PM.
Tags
None
Referenced Files
F15293310: D16968.id40836.diff
Wed, Mar 5, 3:50 AM
Unknown Object (File)
Thu, Feb 27, 3:55 AM
Unknown Object (File)
Tue, Feb 18, 12:07 PM
Unknown Object (File)
Feb 9 2025, 2:55 AM
Unknown Object (File)
Jan 31 2025, 10:42 PM
Unknown Object (File)
Jan 30 2025, 4:26 PM
Unknown Object (File)
Jan 27 2025, 12:45 PM
Unknown Object (File)
Jan 24 2025, 6:09 PM
Subscribers

Details

Summary

Fixes T11935. Safari even with appearance: none still assigns margin to selects. Reset margin to 0.

Test Plan

Review selects on Safari, Chrome.

Diff Detail

Repository
rP Phabricator
Branch
safari-margin (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 14722
Build 19236: Run Core Tests
Build 19235: arc lint + arc unit

Event Timeline

chad retitled this revision from to Remove default margin on selects.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 1 2016, 5:07 PM
This revision was automatically updated to reflect the committed changes.