Remove default margin on selects
ClosedPublic
Actions

Authored by chad on Dec 1 2016, 5:05 PM.

Tags

None

Referenced Files

	F13200445: D16968.id40836.diff
	Tue, May 14, 12:12 AM

	F13182611: D16968.diff
	Fri, May 10, 12:04 AM

	Unknown Object (File)
	Wed, Apr 24, 10:39 AM

	Unknown Object (File)
	Wed, Apr 24, 10:39 AM

	Unknown Object (File)
	Wed, Apr 24, 10:39 AM

	Unknown Object (File)
	Wed, Apr 24, 10:39 AM

	Unknown Object (File)
	Fri, Apr 19, 5:47 PM

	Unknown Object (File)
	Apr 12 2024, 10:22 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T11935: Misaligned UI elements in Differential UI

Commits

rP98057091f67c: Remove default margin on selects

Summary

Fixes T11935. Safari even with appearance: none still assigns margin to selects. Reset margin to 0.

Test Plan

Review selects on Safari, Chrome.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 40836.Dec 1 2016, 5:05 PM

chad retitled this revision from to Remove default margin on selects.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T11935: Misaligned UI elements in Differential UI.

Herald added a subscriber: Korvin. · View Herald TranscriptDec 1 2016, 5:05 PM

epriestley accepted this revision.Dec 1 2016, 5:07 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Dec 1 2016, 5:07 PM

Closed by commit rP98057091f67c: Remove default margin on selects (authored by chad, committed by chad). · Explain WhyDec 1 2016, 5:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

phui/

phui-form.css

1 line

Diff 40837

View Options

resources/celerity/map.php