Page MenuHomePhabricator

Close lightbox when clicking on image-frame
ClosedPublic

Authored by chad on Nov 29 2016, 5:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 3:49 AM
Unknown Object (File)
Thu, Apr 11, 3:49 AM
Unknown Object (File)
Thu, Apr 11, 3:49 AM
Unknown Object (File)
Thu, Apr 11, 3:49 AM
Unknown Object (File)
Wed, Apr 10, 11:51 AM
Unknown Object (File)
Thu, Apr 4, 6:28 PM
Unknown Object (File)
Thu, Apr 4, 11:48 AM
Unknown Object (File)
Wed, Apr 3, 9:19 PM
Subscribers
Tokens
"Dat Boi" token, awarded by cspeckmim.

Details

Summary

Ref T3612. Moves the listener to the frame of the image.

Test Plan

Click on image, no close, click on grey frame, closes image. Test image and document, clicking on arrows.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Close lightbox when clicking on image-frame.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T3612: Lightbox v2.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 29 2016, 6:34 PM
This revision was automatically updated to reflect the committed changes.