Page MenuHomePhabricator

Add a "query compiler" to convert user search queries into a form MySQL likes

Authored by epriestley on Nov 24 2016, 3:32 PM.



Ref T11741. Ref T10642.

By default, MySQL runs query cat dog as "cat OR dog". Users expect "cat AND dog".

For users using MySQL, we instruct them to fix this by changing ft_boolean_syntax. However:

  • You can't edit this in RDS (T10642).
  • There's no similar option for InnoDB (T11741).

Instead, we can parse the query ourselves, and submit +"cat" +"dog" to MySQL, using whatever syntax it is configured for. This will also let us simplify setup since users won't need to change this setting any more.

This just implements a parser/compiler and test cases. It does not yet change search beahvior.

Test Plan

Added and executed unit tests. Ran some of the resulting queries in MySQL to make sure it did what I was expecting.

Diff Detail

rPHU libphutil
Lint OK
Unit Tests OK
Build Status
Buildable 14658
Build 19143: Run Core Tests
Build 19142: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40770.Nov 24 2016, 3:32 PM
epriestley retitled this revision from to Add a "query compiler" to convert user search queries into a form MySQL likes.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley updated this revision to Diff 40771.Nov 24 2016, 4:13 PM
  • Improve error message for trailing operators, by showing the operator.
  • Parse cat"dog".
  • Reject cat"dog.
chad accepted this revision.Nov 24 2016, 4:41 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 24 2016, 4:41 PM
This revision was automatically updated to reflect the committed changes.