HomePhabricator

Add a "query compiler" to convert user search queries into a form MySQL likes

Authored by epriestley on Nov 24 2016, 3:21 PM.

Description

Add a "query compiler" to convert user search queries into a form MySQL likes

Summary:
Ref T11741. Ref T10642.

By default, MySQL runs query cat dog as "cat OR dog". Users expect "cat AND dog".

For users using MySQL, we instruct them to fix this by changing ft_boolean_syntax. However:

  • You can't edit this in RDS (T10642).
  • There's no similar option for InnoDB (T11741).

Instead, we can parse the query ourselves, and submit +"cat" +"dog" to MySQL, using whatever syntax it is configured for. This will also let us simplify setup since users won't need to change this setting any more.

This just implements a parser/compiler and test cases. It does not yet change search beahvior.

Test Plan: Added and executed unit tests. Ran some of the resulting queries in MySQL to make sure it did what I was expecting.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10642, T11741

Differential Revision: https://secure.phabricator.com/D16938