Page MenuHomePhabricator
Differential D16933

Implement a revision resolver for `arc browse <commit>`
ClosedPublic
Actions

Authored by epriestley on Nov 23 2016, 7:50 PM.
Tags
None
Referenced Files
F18094235: D16933.id.diff
Thu, Aug 7, 10:02 PM
F18086351: D16933.id40762.diff
Tue, Aug 5, 9:22 PM
F18081269: D16933.id40757.diff
Mon, Aug 4, 11:22 PM
F18068752: D16933.id.diff
Mon, Aug 4, 3:20 PM
F18049053: D16933.diff
Sun, Aug 3, 3:12 PM
Unknown Object (File)
Jun 20 2025, 6:50 PM
Unknown Object (File)
Jun 15 2025, 4:24 PM
Unknown Object (File)
Jun 5 2025, 10:28 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10895: Support`arc browse --revision <commit>` and make `arc browse` with no arguments mean `... --revision HEAD`
Commits
rARC84857e48900e: Implement a revision resolver for `arc browse <commit>`
Summary

Ref T10895. This allows arc browse <commit name> to resolve to a revision, if an associated open revision exists.

Test Plan

Ran arc browse with various arguments.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40757.Nov 23 2016, 7:50 PM
epriestley retitled this revision from to Implement a revision resolver for `arc browse <commit>`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10895: Support`arc browse --revision <commit>` and make `arc browse` with no arguments mean `... --revision HEAD`.
epriestley mentioned this in T10895: Support`arc browse --revision <commit>` and make `arc browse` with no arguments mean `... --revision HEAD`.Nov 23 2016, 8:07 PM
chad accepted this revision.Nov 23 2016, 8:57 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 23 2016, 8:57 PM
Closed by commit rARC84857e48900e: Implement a revision resolver for `arc browse <commit>` (authored by epriestley, committed by epriestley). · Explain WhyNov 23 2016, 9:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 40762

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/browse/loader/ArcanistBrowseCommitHardpointLoader.php

Loading...
View Options

src/browse/loader/ArcanistBrowseCommitURIHardpointLoader.php

Loading...
View Options

src/browse/loader/ArcanistBrowseRevisionURIHardpointLoader.php

Loading...
View Options

src/browse/workflow/ArcanistBrowseWorkflow.php

Loading...
View Options

src/loader/ArcanistGitCommitMessageHardpointLoader.php

Loading...
View Options

src/loader/ArcanistGitRevisionHardpointLoader.php

Loading...
View Options

src/ref/ArcanistRevisionRef.php

Loading...
Phabricator · Built by Phacility