Page MenuHomePhabricator

Fix a couple of partition migration bugs
ClosedPublic

Authored by epriestley on Nov 22 2016, 6:52 PM.
Tags
None
Referenced Files
F14355273: D16916.id40727.diff
Thu, Dec 19, 5:43 PM
Unknown Object (File)
Thu, Dec 19, 3:08 AM
Unknown Object (File)
Thu, Dec 19, 3:08 AM
Unknown Object (File)
Thu, Dec 19, 3:08 AM
Unknown Object (File)
Wed, Dec 18, 2:14 PM
Unknown Object (File)
Wed, Dec 18, 2:14 PM
Unknown Object (File)
Mon, Dec 9, 8:11 AM
Unknown Object (File)
Mon, Dec 9, 6:50 AM
Subscribers
None

Details

Summary

Ref T11044. Few issues here:

  • The PhutilProxyException is missing an argument (hit this while in read-only mode).
  • The $ref_key is unused.
  • When you add a new master to an existing cluster, we can incorrectly apply .php patches which we should not reapply. Instead, mark them as already-applied.
Test Plan
  • Poked this locally, but will initialize secure004 as an empty master to be sure.

Diff Detail

Repository
rP Phabricator
Branch
partition10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14616
Build 19083: Run Core Tests
Build 19082: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix a couple of partition migration bugs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
avivey added a reviewer: avivey.
This revision is now accepted and ready to land.Nov 22 2016, 6:55 PM
This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.