Adds a comment box, you can put text into it, hit enter, and see it come back.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T3612: Lightbox v2
- Commits
- rP88a966993be1: Ajax commenting on lightbox images
Put text into box, see it come back.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- file-comment (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 14603 Build 19063: Run Core Tests Build 19062: arc lint + arc unit
Event Timeline
Comment Actions
I seem to recall you wanting to do this all in EditEngine, but you'd have to do that part?
| src/applications/files/controller/PhabricatorFileLightboxController.php | ||
|---|---|---|
| 40 | I'll clean this up if I get to land this. | |
Comment Actions
Yeah, this is fine. Seems real bizarre to me to put chatbox semantics in a lightbox, but whatevs. I'll consolidate this eventually.
Comment Actions
We can try it, maybe it won't feel weird in practice. But I wouldn't expect send-on-enter when commenting on files normally.
Comment Actions
I just tossed this all together to get it working, hadn't really put a lot of thought into it. copy-pasta'd the easiest thing.
This comment was removed by epriestley.