Page MenuHomePhabricator
Differential D16907

Ajax commenting on lightbox images
ClosedPublic
Actions

Authored by chad on Nov 21 2016, 9:45 PM.
Tags
None
Referenced Files
F15311921: D16907.id40710.diff
Thu, Mar 6, 12:12 PM
F15311861: D16907.id40697.diff
Thu, Mar 6, 11:46 AM
F15311856: D16907.id40709.diff
Thu, Mar 6, 11:43 AM
F15309659: D16907.diff
Thu, Mar 6, 7:32 AM
Unknown Object (File)
Tue, Feb 25, 12:57 PM
Unknown Object (File)
Tue, Feb 18, 12:04 PM
Unknown Object (File)
Sat, Feb 15, 1:53 PM
Unknown Object (File)
Wed, Feb 12, 12:41 AM
View All Files
Subscribers
Korvin
• liugev6

Details

Reviewers
epriestley
Maniphest Tasks
T3612: Lightbox v2
Commits
rP88a966993be1: Ajax commenting on lightbox images
Summary

Adds a comment box, you can put text into it, hit enter, and see it come back.

Test Plan

Put text into box, see it come back.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 40697.Nov 21 2016, 9:45 PM
chad retitled this revision from to Ajax commenting on lightbox images..
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptNov 21 2016, 9:45 PM
chad added a comment.Nov 21 2016, 10:28 PM

I seem to recall you wanting to do this all in EditEngine, but you'd have to do that part?

chad retitled this revision from Ajax commenting on lightbox images. to Ajax commenting on lightbox images.Nov 21 2016, 10:28 PM
chad added inline comments.Nov 21 2016, 10:58 PM
src/applications/files/controller/PhabricatorFileLightboxController.php
40

I'll clean this up if I get to land this.

epriestley accepted this revision.Nov 22 2016, 12:20 AM
epriestley edited edge metadata.

Yeah, this is fine. Seems real bizarre to me to put chatbox semantics in a lightbox, but whatevs. I'll consolidate this eventually.

This revision is now accepted and ready to land.Nov 22 2016, 12:20 AM
chad added a comment.Nov 22 2016, 12:34 AM

SoE? I can add a submit button.

epriestley added a comment.Nov 22 2016, 12:37 AM

We can try it, maybe it won't feel weird in practice. But I wouldn't expect send-on-enter when commenting on files normally.

chad added a comment.Nov 22 2016, 12:44 AM

I just tossed this all together to get it working, hadn't really put a lot of thought into it. copy-pasta'd the easiest thing.

chad updated this revision to Diff 40709.Nov 22 2016, 4:14 AM
chad edited edge metadata.
  • make wider
  • use profile photos
  • add submit button
chad added a task: T3612: Lightbox v2.Nov 22 2016, 4:19 AM
Closed by commit rP88a966993be1: Ajax commenting on lightbox images (authored by chad, committed by chad). · Explain WhyNov 22 2016, 4:19 AM
This revision was automatically updated to reflect the committed changes.
• liugev6 removed a commit: rP88a966993be1: Ajax commenting on lightbox images.Nov 22 2016, 8:51 AM
• liugev6 added a subscriber: • liugev6.Nov 22 2016, 8:53 AM
In D16907#199999, @chad wrote:

SoE? I can add a submit button.

• liugev6 added a comment.Nov 22 2016, 8:56 AM
This comment was removed by epriestley.
epriestley added a commit: rP88a966993be1: Ajax commenting on lightbox images.Nov 22 2016, 12:09 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
40 lines
src/
applications/
files/
controller/
71 lines
webroot/
rsrc/
css/
phui/
37 lines
6 lines
js/
core/
13 lines

Diff 40710

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileLightboxController.php

Loading...
View Options

webroot/rsrc/css/phui/phui-comment-panel.css

Loading...
View Options

webroot/rsrc/css/phui/phui-lightbox.css

Loading...
View Options

webroot/rsrc/js/core/behavior-lightbox-attachments.js

Loading...
Phabricator · Built by Phacility