Page MenuHomePhabricator

Ajax commenting on lightbox images
ClosedPublic

Authored by chad on Nov 21 2016, 9:45 PM.

Details

Summary

Adds a comment box, you can put text into it, hit enter, and see it come back.

Test Plan

Put text into box, see it come back.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

chad updated this revision to Diff 40697.Nov 21 2016, 9:45 PM
chad retitled this revision from to Ajax commenting on lightbox images..
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a comment.Nov 21 2016, 10:28 PM

I seem to recall you wanting to do this all in EditEngine, but you'd have to do that part?

chad retitled this revision from Ajax commenting on lightbox images. to Ajax commenting on lightbox images.Nov 21 2016, 10:28 PM
chad added inline comments.Nov 21 2016, 10:58 PM
src/applications/files/controller/PhabricatorFileLightboxController.php
40

I'll clean this up if I get to land this.

epriestley accepted this revision.Nov 22 2016, 12:20 AM
epriestley edited edge metadata.

Yeah, this is fine. Seems real bizarre to me to put chatbox semantics in a lightbox, but whatevs. I'll consolidate this eventually.

This revision is now accepted and ready to land.Nov 22 2016, 12:20 AM
chad added a comment.Nov 22 2016, 12:34 AM

SoE? I can add a submit button.

We can try it, maybe it won't feel weird in practice. But I wouldn't expect send-on-enter when commenting on files normally.

chad added a comment.Nov 22 2016, 12:44 AM

I just tossed this all together to get it working, hadn't really put a lot of thought into it. copy-pasta'd the easiest thing.

chad updated this revision to Diff 40709.Nov 22 2016, 4:14 AM
chad edited edge metadata.
  • make wider
  • use profile photos
  • add submit button
This revision was automatically updated to reflect the committed changes.
In D16907#199999, @chad wrote:

SoE? I can add a submit button.

This comment was removed by epriestley.