Page MenuHomePhabricator

Respect user/pass flags to bin/storage for direct DatabaseRef-based queries
ClosedPublic

Authored by epriestley on Nov 19 2016, 4:38 PM.
Tags
None
Referenced Files
F12841097: D16901.id40688.diff
Thu, Mar 28, 8:56 PM
F12837591: D16901.id.diff
Thu, Mar 28, 5:12 PM
F12836753: D16901.id40688.diff
Thu, Mar 28, 4:04 PM
F12834887: D16901.id40687.diff
Thu, Mar 28, 2:51 PM
F12833043: D16901.id.diff
Thu, Mar 28, 1:48 PM
F12820745: D16901.diff
Thu, Mar 28, 6:24 AM
F12816930: D16901.id40688.diff
Thu, Mar 28, 3:58 AM
F12816928: D16901.id40687.diff
Thu, Mar 28, 3:58 AM
Subscribers
None

Details

Summary

Ref T11893. Previously, we excuted all bin/storage queries through StorageManagementAPI objects.

After D16848, we execute some queries through PhabricatorDatabaseRef. However, the refs we use weren't getting passed the -u / -p flags correctly, for specifying alternate administrative credentials.

Test Plan
  • Created a second account (trunk).
  • Ran bin/storage -u trunk.
  • Made libphutil throw when not connecting as that user.
  • Before patch: some connections incorrectly used the default user, "root".
  • After patch: all connections correctly used the configured user, "trunk".

Diff Detail

Repository
rP Phabricator
Branch
user1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 14580
Build 19026: Run Core Tests
Build 19025: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Respect user/pass flags to bin/storage for direct DatbaseRef-based queries.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 19 2016, 4:38 PM
epriestley retitled this revision from Respect user/pass flags to bin/storage for direct DatbaseRef-based queries to Respect user/pass flags to bin/storage for direct DatabaseRef-based queries.Nov 19 2016, 4:38 PM
epriestley edited edge metadata.
This revision was automatically updated to reflect the committed changes.