Page MenuHomePhabricator

Respect user/pass flags to bin/storage for direct DatabaseRef-based queries
ClosedPublic

Authored by epriestley on Nov 19 2016, 4:38 PM.
Tags
None
Referenced Files
F11183824: D16901.id40688.diff
Mon, Oct 3, 8:16 AM
F11181767: D16901.diff
Sun, Oct 2, 11:50 PM
Unknown Object (File)
Fri, Sep 30, 8:13 PM
Unknown Object (File)
Thu, Sep 29, 8:05 PM
Unknown Object (File)
Wed, Sep 28, 5:59 PM
Unknown Object (File)
Sat, Sep 17, 5:44 AM
Unknown Object (File)
Aug 20 2022, 7:59 AM
Unknown Object (File)
Aug 17 2022, 10:46 AM
Subscribers
None

Details

Summary

Ref T11893. Previously, we excuted all bin/storage queries through StorageManagementAPI objects.

After D16848, we execute some queries through PhabricatorDatabaseRef. However, the refs we use weren't getting passed the -u / -p flags correctly, for specifying alternate administrative credentials.

Test Plan
  • Created a second account (trunk).
  • Ran bin/storage -u trunk.
  • Made libphutil throw when not connecting as that user.
  • Before patch: some connections incorrectly used the default user, "root".
  • After patch: all connections correctly used the configured user, "trunk".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Respect user/pass flags to bin/storage for direct DatbaseRef-based queries.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 19 2016, 4:38 PM
epriestley retitled this revision from Respect user/pass flags to bin/storage for direct DatbaseRef-based queries to Respect user/pass flags to bin/storage for direct DatabaseRef-based queries.Nov 19 2016, 4:38 PM
epriestley edited edge metadata.
This revision was automatically updated to reflect the committed changes.