storage for direct DatabaseRef-based queries
ClosedPublic
Actions

Authored by epriestley on Nov 19 2016, 4:38 PM.

Details

Reviewers

chad

Maniphest Tasks

T11893: storage upgrade claims it lacks permissions, but is running as root mysql user

Commits

rP74a0e5cd7930: (stable) Respect user/pass flags to bin/storage for direct DatabaseRef-based…
rP8fbb411a9a72: Respect user/pass flags to bin/storage for direct DatabaseRef-based queries

Summary

Ref T11893. Previously, we excuted all bin/storage queries through StorageManagementAPI objects.

After D16848, we execute some queries through PhabricatorDatabaseRef. However, the refs we use weren't getting passed the -u / -p flags correctly, for specifying alternate administrative credentials.

Test Plan

Created a second account (trunk).
Ran bin/storage -u trunk.
Made libphutil throw when not connecting as that user.
Before patch: some connections incorrectly used the default user, "root".
After patch: all connections correctly used the configured user, "trunk".

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40687.Nov 19 2016, 4:38 PM

epriestley retitled this revision from to Respect user/pass flags to bin/storage for direct DatbaseRef-based queries.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11893: storage upgrade claims it lacks permissions, but is running as root mysql user.

epriestley mentioned this in T11893: storage upgrade claims it lacks permissions, but is running as root mysql user.Nov 19 2016, 4:38 PM

chad accepted this revision.Nov 19 2016, 4:38 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 19 2016, 4:38 PM

epriestley retitled this revision from Respect user/pass flags to bin/storage for direct DatbaseRef-based queries to Respect user/pass flags to bin/storage for direct DatabaseRef-based queries.Nov 19 2016, 4:38 PM

epriestley edited edge metadata.

Closed by commit rP8fbb411a9a72: Respect user/pass flags to bin/storage for direct DatabaseRef-based queries (authored by epriestley, committed by epriestley). · Explain WhyNov 19 2016, 4:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

scripts/

sql/

manage_storage.php

3 lines

Diff 40688

View Options

scripts/sql/manage_storage.php

Respect user/pass flags to bin/storage for direct DatabaseRef-based queriesClosedPublicActions