Differential D16883

Add back green drag and drop text area highlight
ClosedPublic
Actions

Authored by chad on Nov 17 2016, 12:29 AM.

Details

Reviewers

epriestley

Maniphest Tasks

T11884: Comment text areas lost the green highlight when a file is dropped into them in the recent comment update

Commits

rP42f30834084e: Add back green drag and drop text area highlight

Summary

Fixes T11884. Better specificity and color.

Test Plan

Drag and drop. Submit.

Diff Detail

Repository

rP Phabricator

Branch

css-drag (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14534
Build 18957: Run Core Tests
Build 18956: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40646.Nov 17 2016, 12:29 AM

chad retitled this revision from to Add back green drag and drop text area highlight.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T11884: Comment text areas lost the green highlight when a file is dropped into them in the recent comment update.

Herald added a subscriber: Korvin. · View Herald TranscriptNov 17 2016, 12:29 AM

epriestley accepted this revision.Nov 17 2016, 12:35 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 17 2016, 12:35 AM

Closed by commit rP42f30834084e: Add back green drag and drop text area highlight (authored by chad, committed by chad). · Explain WhyNov 17 2016, 12:35 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

phui/

phui-form-view.css

6 lines

Diff 40646

View Options

resources/celerity/map.php