Differential D16872

Document calendar summary icons
ClosedPublic
Actions

Authored by epriestley on Nov 15 2016, 8:46 PM.

Tags

None

Referenced Files

	F15536076: D16872.id40622.diff
	Thu, Apr 24, 8:20 AM

	F15464516: D16872.id40622.diff
	Wed, Apr 2, 10:10 AM

	F15451998: D16872.id40625.diff
	Sat, Mar 29, 1:04 AM

	F15445728: D16872.id.diff
	Thu, Mar 27, 3:42 PM

	F15440410: D16872.diff
	Wed, Mar 26, 12:43 PM

	F15392591: D16872.id40622.diff
	Mar 15 2025, 4:12 PM

	F15391611: D16872.id40622.diff
	Mar 15 2025, 10:44 AM

	F15391327: D16872.id40622.diff
	Mar 15 2025, 9:24 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T11809: Calendar v1 Errata Mark II

Commits

rPc7f2e4a9246e: Document calendar summary icons

Summary

Fixes T11809. Ref

Explicitly document the summary icon hints -- I don't think these are too hard to figure out (and maybe this stuff should just go in the tooltips) but we can start here.
Use color + shape to distinguish between "cancelled" and "declined", not just color (for users with vision accessibility issues).
Translate a "minute(s)" string into sensible English.
Use RSVP status on the month view green circle thing.

Test Plan

Read docs.
Looked at month view.
Read reminder mail.
Viewed month view mobile view.

Diff Detail

Repository

Branch

cicons1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14511
Build 18923: Run Core Tests
Build 18922: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40622.Nov 15 2016, 8:46 PM

epriestley retitled this revision from to Document calendar summary icons.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11809: Calendar v1 Errata Mark II.

chad accepted this revision.Nov 15 2016, 9:36 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 15 2016, 9:36 PM

Closed by commit rPc7f2e4a9246e: Document calendar summary icons (authored by epriestley, committed by epriestley). · Explain WhyNov 15 2016, 9:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

query/

PhabricatorCalendarEventSearchEngine.php

4 lines

storage/

PhabricatorCalendarEvent.php

12 lines

people/

controller/

PhabricatorPeopleProfileViewController.php

3 lines

docs/

user/

userguide/

calendar.diviner

16 lines

infrastructure/

internationalization/

translation/

PhabricatorUSEnglishTranslation.php

8 lines

Diff 40622

src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php

Loading...

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...

src/applications/people/controller/PhabricatorPeopleProfileViewController.php

Loading...

src/docs/user/userguide/calendar.diviner

Loading...

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

Loading...