Page MenuHomePhabricator
Differential D16871

Add subtitle to PhamePost
ClosedPublic
Actions

Authored by chad on Nov 15 2016, 7:50 PM.
Tags
None
Referenced Files
F14330604: D16871.diff
Wed, Dec 18, 3:37 PM
Unknown Object (File)
Fri, Dec 6, 6:44 PM
Unknown Object (File)
Wed, Dec 4, 3:52 AM
Unknown Object (File)
Thu, Nov 28, 3:22 AM
Unknown Object (File)
Sat, Nov 23, 9:56 PM
Unknown Object (File)
Nov 9 2024, 12:38 PM
Unknown Object (File)
Nov 9 2024, 12:37 PM
Unknown Object (File)
Nov 9 2024, 12:37 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP015ead6e7b85: Add subtitle to PhamePost
Summary

No view engine yet (adding header image next), but adds subtitle to display like PhameBlog

Test Plan

Add a subtitle, remove a subtitle.

Diff Detail

Repository
rP Phabricator
Branch
blog-post-super-header (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14509
Build 18920: Run Core Tests
Build 18919: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40620.Nov 15 2016, 7:50 PM
chad retitled this revision from to Add subtitle to PhamePost.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptNov 15 2016, 7:50 PM
epriestley accepted this revision.Nov 15 2016, 7:51 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 15 2016, 7:51 PM
Closed by commit rP015ead6e7b85: Add subtitle to PhamePost (authored by chad, committed by chad). · Explain WhyNov 15 2016, 8:02 PM
This revision was automatically updated to reflect the committed changes.
chad mentioned this in Z1336: General Chat.Nov 28 2016, 1:53 AM

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
2 lines
src/
applications/
phame/
editor/
8 lines
7 lines
storage/
2 lines
21 lines

Diff 40620

View Options

resources/sql/autopatches/20161115.phamepost.01.subtitle.sql

Loading...
View Options

src/applications/phame/editor/PhamePostEditEngine.php

Loading...
View Options

src/applications/phame/editor/PhamePostEditor.php

Loading...
View Options

src/applications/phame/storage/PhamePost.php

Loading...
View Options

src/applications/phame/storage/PhamePostTransaction.php

Loading...
Phabricator · Built by Phacility