Differential D16837

Fix two error strings in the diffusion.uri.edit Conduit method
ClosedPublic
Actions

Authored by epriestley on Nov 10 2016, 2:21 PM.

Details

Reviewers

chad

Maniphest Tasks

T11839: Invalid translation for diffusion.uri.edit display

Commits

rPff677c1964b1: Fix two error strings in the diffusion.uri.edit Conduit method

Summary

Fixes T11839. Both are missing a parameter and one is a copy/paste slop.

Test Plan

Diff Detail

Repository

rP Phabricator

Branch

conduit1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14436
Build 18813: Run Core Tests
Build 18812: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40545.Nov 10 2016, 2:21 PM

epriestley retitled this revision from to Fix two error strings in the diffusion.uri.edit Conduit method.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11839: Invalid translation for diffusion.uri.edit display.

epriestley mentioned this in T11839: Invalid translation for diffusion.uri.edit display.Nov 10 2016, 2:21 PM

chad accepted this revision.Nov 10 2016, 3:17 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 10 2016, 3:17 PM

Closed by commit rPff677c1964b1: Fix two error strings in the diffusion.uri.edit Conduit method (authored by epriestley, committed by epriestley). · Explain WhyNov 10 2016, 4:55 PM

This revision was automatically updated to reflect the committed changes.

• cxie added a subscriber: • cxie.Nov 13 2016, 3:32 PM

• cxie added inline comments.

src/applications/diffusion/editor/DiffusionURIEditor.php
313	test
422	test

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

editor/

DiffusionURIEditor.php

4 lines

Diff 40545

View Options

src/applications/diffusion/editor/DiffusionURIEditor.php

Fix two error strings in the diffusion.uri.edit Conduit methodClosedPublicActions