Page MenuHomePhabricator
Differential D16832

Normalize form inputs a little
ClosedPublic
Actions

Authored by chad on Nov 10 2016, 12:32 AM.
Tags
None
Referenced Files
F14352958: D16832.diff
Thu, Dec 19, 3:48 PM
Unknown Object (File)
Thu, Dec 12, 6:25 AM
Unknown Object (File)
Wed, Dec 11, 2:21 PM
Unknown Object (File)
Sat, Dec 7, 5:37 PM
Unknown Object (File)
Sat, Nov 23, 2:14 AM
Unknown Object (File)
Nov 19 2024, 1:44 AM
Unknown Object (File)
Nov 9 2024, 1:55 AM
Unknown Object (File)
Oct 23 2024, 6:02 PM
View All Files
Subscribers
Korvin
Tokens
"Y So Serious" token, awarded by epriestley.

Details

Reviewers
epriestley
Commits
rP554b3c3810a5: Normalize form inputs a little
Summary

Lots of minor details, colors, spacing, padding.

Test Plan

View carefully in create task, mobile create task, comment form, tokenizers.

pasted_file (551×769 px, 58 KB)

Diff Detail

Repository
rP Phabricator
Branch
normalize-forms (branched from master)
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/css/phui/phui-form.css:112TXT3Line Too Long
Unit
No Test Coverage
Build Status
Buildable 14426
Build 18798: Run Core Tests
Build 18797: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40536.Nov 10 2016, 12:32 AM
chad retitled this revision from to Normalize form inputs a little.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptNov 10 2016, 12:32 AM
chad edited the test plan for this revision. (Show Details)Nov 10 2016, 12:34 AM
epriestley accepted this revision.Nov 10 2016, 12:34 AM
epriestley edited edge metadata.
epriestley added inline comments.
webroot/rsrc/css/phui/phui-form.css
112

Since we automatically turn stuff into data URIs you could put this as a .png or whatever on disk, too, but whatevs.

This revision is now accepted and ready to land.Nov 10 2016, 12:34 AM
chad added a comment.Nov 10 2016, 12:37 AM

I don't have the file to do that. :3

epriestley added a comment.Nov 10 2016, 12:38 AM

I can help with that!

$ echo iVBORw0KGgoAAAANSUhEUgAAABAAAAAUCAMAAACzvE1FAAAADFBMVEUzMzMzMzMzMzMzMzMKAG/3AAAAA3RSTlMAf4C/aSLHAAAAPElEQVR42q3NMQ4AIAgEQTn//2cLdRKppSGzBYwzVXvznNWs8C58CiussPJj8h6NwgorrKRdTvuV9v16Afn0AYFOB7aYAAAAAElFTkSuQmCC | base64 -D > file.png

file.png (20×16 px, 156 B)

file.png156 BDownload

Closed by commit rP554b3c3810a5: Normalize form inputs a little (authored by chad, committed by chad). · Explain WhyNov 10 2016, 12:42 AM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Nov 10 2016, 12:47 AM

ehhh, remind me when I un-round everything again in 2 years.

epriestley awarded a token.Nov 10 2016, 12:48 AM

If we had the reminder feature we could use it right now!

avivey mentioned this in E1209: Pull that into png.Nov 10 2016, 12:50 AM

Revision Contents
Changeset List

PathSize
resources/
celerity/
30 lines
webroot/
rsrc/
css/
aphront/
5 lines
core/
26 lines
phui/
29 lines
3 lines
21 lines

Diff 40536

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/aphront/tokenizer.css

Loading...
View Options

webroot/rsrc/css/core/remarkup.css

Loading...
View Options

webroot/rsrc/css/phui/phui-comment-form.css

Loading...
View Options

webroot/rsrc/css/phui/phui-form-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-form.css

Loading...
Phabricator · Built by Phacility