Page MenuHomePhabricator

In prose diff dialogs (like "Show Details" in transactions), show "old", "new" and "diff" tabs
ClosedPublic

Authored by epriestley on Nov 7 2016, 7:23 PM.

Details

Summary

Ref T7643. When you do something like this:

  • Edit a task description.
  • Click "Show Details" on the resulting transaction.
  • Get a prose diff dialog showing the change.

...now add some "Old" and "New" tabs. These are useful for:

  • reverting to the old text by copy/pasting;
  • reading just the new/old text if the diff is noisy;
  • sometimes just nice to have?

(This looks a little rough but I didn't want to put a negative margin on tab groups inside dialogs? Not sure what the best fix here is.)

Test Plan

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley retitled this revision from to In prose diff dialogs (like "Show Details" in transactions), show "old", "new" and "diff" tabs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

You can add a class to the dialog, we do this with object-lists:

chad edited edge metadata.
This revision is now accepted and ready to land.Nov 7 2016, 8:53 PM
epriestley edited edge metadata.
  • Uh just kind of fake it, maybe I'll clean this up when I fix Paste/Config code diffs? ๐Ÿ—
This revision was automatically updated to reflect the committed changes.