Page MenuHomePhabricator

Probably fix some display issues with all-day events?
ClosedPublic

Authored by epriestley on Nov 7 2016, 6:44 PM.
Tags
None
Referenced Files
F14038861: D16815.id40490.diff
Mon, Nov 11, 2:30 AM
F13978475: D16815.diff
Oct 18 2024, 11:23 PM
F13963329: D16815.diff
Oct 15 2024, 3:17 PM
F13957845: D16815.id40490.diff
Oct 14 2024, 11:38 AM
Unknown Object (File)
Sep 8 2024, 3:47 AM
Unknown Object (File)
Sep 5 2024, 10:04 PM
Unknown Object (File)
Sep 5 2024, 10:04 PM
Unknown Object (File)
Sep 5 2024, 10:04 PM
Subscribers
None

Details

Summary

Ref T11801. These are pretty fiddly because users expect to see the end time for timed events ("10 AM - 11 AM" is ONE hour long) but not for all-day events ("Nov 2 - Nov 3" is TWO days long!)

We also want to store the thing the user actually entered so we don't lose data if they un-all-day the event later.

This may take a little more fiddling since it feels a little shaky, but I couldn't break this version immediately.

Test Plan

Imported a French holiday, got proper display in the UI.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Probably fix some display issues with all-day events?.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 7 2016, 6:50 PM
This revision was automatically updated to reflect the committed changes.