Differential D16812

In Calendar ICS imports, parse "Etc/GMT" as "UTC"
ClosedPublic
Actions

Authored by epriestley on Nov 7 2016, 5:25 PM.

Details

Reviewers

chad

Maniphest Tasks

T11801: Calendar: ICS Import Errata

Commits

rPHU829553c1da82: In Calendar ICS imports, parse "Etc/GMT" as "UTC"

Summary

Ref T11801. This is a legacy timezone which is effectively equivalent to "UTC" (they differ by no more than a second, owing to variations in the speed of the earth's rotation).

Test Plan

Ran unit tests.
Faked an entry in the map to make a test fail.

Diff Detail

Repository

rPHU libphutil

Branch

cal1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14377
Build 18721: Run Core Tests
Build 18720: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40486.Nov 7 2016, 5:25 PM

epriestley retitled this revision from to In Calendar ICS imports, parse "Etc/GMT" as "UTC".

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11801: Calendar: ICS Import Errata.

chad accepted this revision.Nov 7 2016, 5:28 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 7 2016, 5:28 PM

Closed by commit rPHU829553c1da82: In Calendar ICS imports, parse "Etc/GMT" as "UTC" (authored by epriestley, committed by epriestley). · Explain WhyNov 7 2016, 5:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

calendar/

ics/

PhutilICSParser.php

9 lines

Diff 40486

View Options

src/parser/calendar/ics/PhutilICSParser.php

In Calendar ICS imports, parse "Etc/GMT" as "UTC"ClosedPublicActions