Page MenuHomePhabricator
Differential D16812

In Calendar ICS imports, parse "Etc/GMT" as "UTC"
ClosedPublic
Actions

Authored by epriestley on Nov 7 2016, 5:25 PM.
Tags
None
Referenced Files
F14086874: D16812.id40487.diff
Sat, Nov 23, 5:30 PM
Unknown Object (File)
Tue, Nov 12, 7:57 PM
Unknown Object (File)
Oct 14 2024, 1:23 AM
Unknown Object (File)
Oct 8 2024, 2:52 PM
Unknown Object (File)
Sep 20 2024, 5:04 AM
Unknown Object (File)
Sep 19 2024, 8:49 PM
Unknown Object (File)
Sep 19 2024, 7:20 PM
Unknown Object (File)
Sep 15 2024, 1:21 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11801: Calendar: ICS Import Errata
Commits
rPHU829553c1da82: In Calendar ICS imports, parse "Etc/GMT" as "UTC"
Summary

Ref T11801. This is a legacy timezone which is effectively equivalent to "UTC" (they differ by no more than a second, owing to variations in the speed of the earth's rotation).

Test Plan
  • Ran unit tests.
  • Faked an entry in the map to make a test fail.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40486.Nov 7 2016, 5:25 PM
epriestley retitled this revision from to In Calendar ICS imports, parse "Etc/GMT" as "UTC".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11801: Calendar: ICS Import Errata.
chad accepted this revision.Nov 7 2016, 5:28 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 7 2016, 5:28 PM
Closed by commit rPHU829553c1da82: In Calendar ICS imports, parse "Etc/GMT" as "UTC" (authored by epriestley, committed by epriestley). · Explain WhyNov 7 2016, 5:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
parser/
calendar/
ics/
9 lines

Diff 40487

View Options

src/parser/calendar/ics/PhutilICSParser.php

Loading...
Phabricator · Built by Phacility