Page MenuHomePhabricator
Differential D16801

Raise ICS warnings in Phabricator on ICS import
ClosedPublic
Actions

Authored by epriestley on Nov 4 2016, 10:39 PM.
Tags
None
Referenced Files
F13090799: D16801.diff
Thu, Apr 25, 2:34 AM
Unknown Object (File)
Sun, Apr 21, 11:24 PM
Unknown Object (File)
Fri, Apr 19, 5:34 PM
Unknown Object (File)
Fri, Apr 19, 11:46 AM
Unknown Object (File)
Thu, Apr 11, 6:23 AM
Unknown Object (File)
Wed, Apr 3, 7:51 AM
Unknown Object (File)
Mon, Apr 1, 7:37 PM
Unknown Object (File)
Sun, Mar 31, 5:47 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11816: Calendar: Feedback and Suggestions
Commits
rPac8b156e4bb2: Raise ICS warnings in Phabricator on ICS import
Summary

Ref T11816. Depends on D16800. Show warnings generated by ICS import in the UI.

Test Plan

Screen Shot 2016-11-04 at 3.39.03 PM.png (188×1 px, 40 KB)

Diff Detail

Repository
rP Phabricator
Branch
cal1 (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14352
Build 18686: Run Core Tests
Build 18685: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40463.Nov 4 2016, 10:39 PM
epriestley retitled this revision from to Raise ICS warnings in Phabricator on ICS import.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11816: Calendar: Feedback and Suggestions.
epriestley added a parent revision: D16800: When we encounter a fanciful timezone identifier, try to guess what it might mean.
chad accepted this revision.Nov 4 2016, 10:51 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 4 2016, 10:51 PM
Closed by commit rPac8b156e4bb2: Raise ICS warnings in Phabricator on ICS import (authored by epriestley, committed by epriestley). · Explain WhyNov 4 2016, 11:37 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T11816: Calendar: Feedback and Suggestions.Nov 4 2016, 11:54 PM

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
calendar/
import/
11 lines
importlog/
37 lines

Diff 40463

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/calendar/import/PhabricatorCalendarICSImportEngine.php

Loading...
View Options

src/applications/calendar/importlog/PhabricatorCalendarImportICSWarningLogType.php

Loading...
Phabricator · Built by Phacility