Page MenuHomePhabricator
Differential D16789

Remove obsolete Calendar event date storage fields
ClosedPublic
Actions

Authored by epriestley on Nov 1 2016, 11:28 PM.
Tags
None
Referenced Files
F15489672: D16789.id40436.diff
Fri, Apr 11, 11:16 AM
F15472060: D16789.id40437.diff
Sat, Apr 5, 10:47 AM
F15455546: D16789.id40437.diff
Sun, Mar 30, 3:04 AM
F15453846: D16789.diff
Sat, Mar 29, 2:47 PM
F15450011: D16789.id.diff
Fri, Mar 28, 1:27 PM
F15434436: D16789.diff
Mar 25 2025, 3:40 AM
F15399071: D16789.id.diff
Mar 17 2025, 2:44 AM
Unknown Object (File)
Feb 20 2025, 7:46 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11809: Calendar v1 Errata Mark II
Commits
rP3f2f81a1c8ab: Remove obsolete Calendar event date storage fields
Summary

Ref T11809. These have been replaced with more flexible storage that accommodates a wider range of behaviors, including those in the ICS format and RRULEs.

Test Plan
  • Ran migration.
  • Viewed, created, edited events.
  • Grepped for all removed names/symbols.

Diff Detail

Repository
rP Phabricator
Branch
cal2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14326
Build 18646: Run Core Tests
Build 18645: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40436.Nov 1 2016, 11:28 PM
epriestley retitled this revision from to Remove obsolete Calendar event date storage fields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11809: Calendar v1 Errata Mark II.
chad accepted this revision.Nov 2 2016, 2:33 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 2 2016, 2:33 AM
Closed by commit rP3f2f81a1c8ab: Remove obsolete Calendar event date storage fields (authored by epriestley, committed by epriestley). · Explain WhyNov 2 2016, 4:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
2 lines
sql/
autopatches/
17 lines
src/
applications/
calendar/
storage/
49 lines
xaction/
3 lines
webroot/
rsrc/
js/
application/
calendar/

Diff 40436

View Options

resources/celerity/map.php

Loading...
View Options

resources/sql/autopatches/20161101.calendar.02.removecolumns.sql

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...
View Options

src/applications/calendar/xaction/PhabricatorCalendarEventUntilDateTransaction.php

Loading...
View Options

webroot/rsrc/js/application/calendar/behavior-recurring-edit.js

Loading...
Phabricator · Built by Phacility